Updates from CRW 2.2 build scripts #482
Conversation
nickboldt
requested review from
benoitf,
ericwill,
vinokurig and
vitaliy-guliy
as code owners
nickboldt
changed the title
|
Happy path tests passed. |
|
shellcheck should pass after #488 (or at least only fail for these files and not unrelated things) |
|
I think with #481 merged this one can go in now too, right @nickboldt ? |
| @@ -0,0 +1,11 @@ | |||
| [centos-8-for-appstream] | |||
There was a problem hiding this comment.
as you're moving files, maybe we should move specific files for rhel.Dockerfile to rhel folder ?
There was a problem hiding this comment.
there's a lot of logic in place relying on *.repo files in build/dockerfiles/ in various repos. Yes, we could move stuff around again but then we'd have to it for plugin reg, devfile reg, plugin brokers, machine exec, che/crw server, che/crw-theia... Not sure it's worth the churn right now.
Change-Id: I777b9353d9634f810598effa51ea88f26983a171 Signed-off-by: nickboldt <nboldt@redhat.com>
Change-Id: Ie8df16a14c44a4ccdaedeb02e045a504de18385a Signed-off-by: nickboldt <nboldt@redhat.com>
… devfile reg script and downstream version Change-Id: Ibb2ae67ac5442e85b9aceba4500b25deb457b9aa Signed-off-by: nickboldt <nboldt@redhat.com>
…/dockerfiles/content_sets_centos8.repo and include baseos repo too Change-Id: Ie2cede8bbf5f9d55089a6e2acd24b8733e1b6003 Signed-off-by: nickboldt <nboldt@redhat.com>
…s_fedora30.repo for consistency/accuracy Change-Id: I732f8d891bded2400bac635c43dd3b212e7b13cc Signed-off-by: nickboldt <nboldt@redhat.com>
…f SCRIPT_DIR Change-Id: I12a670025b18ace6a64f1a2a7201160d751bd594 Signed-off-by: nickboldt <nboldt@redhat.com>
nickboldt
force-pushed
the
update-merge-crw
branch
from
62f17cb to
9d9ac79
Compare
|
Happy path tests passed. |
Change-Id: I6ce96afa77d9791b74dd1d638cbcbcf0c23aff1e Signed-off-by: nickboldt <nboldt@redhat.com>
nickboldt
force-pushed
the
update-merge-crw
branch
from
b69b6f1 to
67356aa
Compare
|
Happy path tests passed. |
3 similar comments
|
Happy path tests passed. |
|
Happy path tests passed. |
|
Happy path tests passed. |
Updates from CRW 2.2 build scripts (to better align up and downstream repos)
Change-Id: I732f8d891bded2400bac635c43dd3b212e7b13cc
Signed-off-by: nickboldt nboldt@redhat.com